Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18158 )
Change subject: [docs] update Transaction Semantics page ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc File docs/transaction_semantics.adoc: http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@57 PS1, Line 57: to readers > This seems a bit confusing Not sure which part, but I tried clarifying. LMK how I can clarify further http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@102 PS1, Line 102: are not fully Atomic > nit: maybe, add more color here to be something like Done http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@169 PS1, Line 169: > nit: maybe, drop this since there is already 'described above' in the end o Done http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@174 PS1, Line 174: can be used to create sessions > Maybe, add an extra paragraph to mention that instead of passing around tra Done http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@188 PS1, Line 188: transaction automatically registers itself as a participant, and is locked for further transactions > Does it make sense to mention how deadlocks are resolved in the scope of mu Done http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@191 PS1, Line 191: > nit: Kudu cluster Done http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@192 PS1, Line 192: : If multiple transactions lock the same tablet, Kudu uses the wait-die scheme to avoid deadlocks when : locking the participant: if a transaction _b_ attempts to lo > IIRC, the default setting for the heartbeating is off, meaning a new transa Done http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@265 PS1, Line 265: > nit: indent Done http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@283 PS1, Line 283: ead committed"] semantics. > nit: does it make sense to clarify that's so even for a transactional sessi Done -- To view, visit http://gerrit.cloudera.org:8080/18158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03554b8b7b497e962f30bf1c84f9c033af4a85c1 Gerrit-Change-Number: 18158 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 19 Jan 2022 20:15:27 +0000 Gerrit-HasComments: Yes
