Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )
Change subject: WIP [common] try to examine Schema::Reset(cols, ...) ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18213/3/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/18213/3/src/kudu/common/schema.cc@285 PS3, Line 285: col_offsets_.clear(); Better to add some unit tests -- To view, visit http://gerrit.cloudera.org:8080/18213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722 Gerrit-Change-Number: 18213 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 12 Feb 2022 02:58:59 +0000 Gerrit-HasComments: Yes
