Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )
Change subject: [common] fix a bug in Schema::Reset(cols, ...) ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@7 PS6, Line 7: fix a bug in Schema::Reset(cols, ...) > How about: Done http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@9 PS6, Line 9: Prior to this patch, Schema::col_offsets_ was not cleared : upon calling Schema::Reset(). This patch addresses the issue. : : A new test scenario is added to cover the corresponding regressions in future. : > How about updating this a bit to describe the essence of the problem. For You are very kind. I would change it. http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc File src/kudu/common/schema-test.cc: http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@319 PS6, Line 319: ColumnSchema("col4", STRING), > Align to 'ColumnSchema' of the row above. Done http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@322 PS6, Line 322: ASSERT_OK(schema.Reset(schema1.colu > Wrap into ASSERT_OK()? Done http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@327 PS6, Line 327: ASSERT_EQ(schema.key_byte_size(), schema1.key_byte_size()); > Could you also add an extra check below? Done http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema.cc@284 PS6, Line 284: col_offsets_.clear(); : col_offsets_.reserve( > nit: consider changing the order to call vector::clear() before calling vec Done -- To view, visit http://gerrit.cloudera.org:8080/18213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722 Gerrit-Change-Number: 18213 Gerrit-PatchSet: 8 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:04:52 +0000 Gerrit-HasComments: Yes
