Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18211 )
Change subject: [java] KUDU-3350 add the support for deleteIgnoreRows ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18211/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/18211/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@334 PS4, Line 334: that have already been deleted. > nit: remove this -- those absent rows might never be there in the first pla Ack http://gerrit.cloudera.org:8080/#/c/18211/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@347 PS4, Line 347: ${numDeletes.value.get(tableName)} > Is this going to be reported as an actual number of deleted rows or just th This is the actual number of deleted rows. See the numDeletes here: case Delete => numDeletes.add((tableName, count)) case DeleteIgnore => numDeletes.add((tableName, count)) http://gerrit.cloudera.org:8080/#/c/18211/4/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/18211/4/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@74 PS4, Line 74: testDuplicateDelete > In addition to this testcase with duplicated delete operations, maybe it's Ack -- To view, visit http://gerrit.cloudera.org:8080/18211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f89ced9ffa4a79f46661873f01c38aefb1d78d5 Gerrit-Change-Number: 18211 Gerrit-PatchSet: 4 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Feb 2022 06:14:50 +0000 Gerrit-HasComments: Yes
