Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18211 )
Change subject: [java] KUDU-3350 add the support for deleteIgnoreRows ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Overall looks good to me! Just wanted to clarify on one small logging question. http://gerrit.cloudera.org:8080/#/c/18211/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/18211/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@347 PS4, Line 347: ${numDeletes.value.get(tableName)} > This is the actual number of deleted rows. See the numDeletes here: Ah, that's interesting. Where does KuduContext get the stats about the number of actually deleted rows when it issues DELETE_IGNORE operations? Does the server side report to the client about that stat? It would be great if you add a comment clarifying on this, commenting about what's reported at the log.info() operator at line 347. http://gerrit.cloudera.org:8080/#/c/18211/8/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/18211/8/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@69 PS8, Line 69: * A simple test to delete rows from an empty table. Thank you very much for adding this new scenario! -- To view, visit http://gerrit.cloudera.org:8080/18211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f89ced9ffa4a79f46661873f01c38aefb1d78d5 Gerrit-Change-Number: 18211 Gerrit-PatchSet: 8 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Feb 2022 22:03:43 +0000 Gerrit-HasComments: Yes
