Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18229 )
Change subject: [thread] Small refactor to improve ThreadMgr performance ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Overall looks good to me, just a few nits. http://gerrit.cloudera.org:8080/#/c/18229/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18229/1//COMMIT_MSG@10 PS1, Line 10: to improve performance BTW, what's the performance gain after this patch applied? Did you have a chance to measure the difference? http://gerrit.cloudera.org:8080/#/c/18229/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/18229/1/src/kudu/util/thread.cc@256 PS1, Line 256: and thread metrics nit: remove this since the metrics are no longer protected by 'lock_' http://gerrit.cloudera.org:8080/#/c/18229/1/src/kudu/util/thread.cc@340 PS1, Line 340: uint64_t ThreadMgr::ReadThreadsStarted() const { : return threads_started_metric_; : } : : uint64_t ThreadMgr::ReadThreadsRunning() const { : return threads_running_metric_; : } nit: maybe, move these methods into the body the 'ThreadMgr' class definition? -- To view, visit http://gerrit.cloudera.org:8080/18229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I219c509c5818b618e864c534bbf40cc4f9a7dc13 Gerrit-Change-Number: 18229 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Feb 2022 18:47:14 +0000 Gerrit-HasComments: Yes
