Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18229 )
Change subject: [thread] Small refactor to improve ThreadMgr performance ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18229/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18229/1//COMMIT_MSG@10 PS1, Line 10: to improve performance > BTW, what's the performance gain after this patch applied? Did you have a Not yet, but I think this improvement is insignificant indeed. http://gerrit.cloudera.org:8080/#/c/18229/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/18229/1/src/kudu/util/thread.cc@256 PS1, Line 256: ThreadCategory> Thr > nit: remove this since the metrics are no longer protected by 'lock_' Done http://gerrit.cloudera.org:8080/#/c/18229/1/src/kudu/util/thread.cc@340 PS1, Line 340: } : return Status::OK(); : } : : void ThreadMgr::AddThread(const pthread_t& pthread_id, const string& name, : const string& category, int64_t tid) { : > nit: maybe, move these methods into the body the 'ThreadMgr' class definiti Done -- To view, visit http://gerrit.cloudera.org:8080/18229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I219c509c5818b618e864c534bbf40cc4f9a7dc13 Gerrit-Change-Number: 18229 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 15 Feb 2022 02:45:59 +0000 Gerrit-HasComments: Yes
