Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18231 )
Change subject: [common] add DCHECK to spot bugs in using Schema ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/18231/1/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/18231/1/src/kudu/common/schema.h@544 PS1, Line 544: // latter involves division by sizeof(ColumnSchema) Wow, TIL. http://gerrit.cloudera.org:8080/#/c/18231/1/src/kudu/common/schema.h@548 PS1, Line 548: DCHECK_EQ(cols_.size(), name_to_index_.size()); nit: in the spirit of catching the problem when it happens, I first thought maybe we ought to put this in the constructors or Reset() calls. OTOH, seems Reset() already has something similar, and it may be a bit uglier spraying this all over the constructors, so feel free to keep this as is. -- To view, visit http://gerrit.cloudera.org:8080/18231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44b73ef06924af6556a7cd3da4a7eec20d12aefc Gerrit-Change-Number: 18231 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 14 Feb 2022 23:18:31 +0000 Gerrit-HasComments: Yes
