Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18231 )
Change subject: [common] add DCHECK to spot bugs in using Schema ...................................................................... [common] add DCHECK to spot bugs in using Schema While reviewing recently posted patch [1], I was looking at the code in src/kudu/common/schema.h and decided to add more DCHECK-like asserts to help catching bugs in the implementation of the Schema class itself and spotting errors at the call sites where Schema objects are used. This patch doesn't contain any functional changes. [1] https://gerrit.cloudera.org/#/c/18213/ Change-Id: I44b73ef06924af6556a7cd3da4a7eec20d12aefc Reviewed-on: http://gerrit.cloudera.org:8080/18231 Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/common/schema.h 1 file changed, 15 insertions(+), 9 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Mahesh Reddy: Looks good to me, but someone else must approve Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/18231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I44b73ef06924af6556a7cd3da4a7eec20d12aefc Gerrit-Change-Number: 18231 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
