Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18211 )
Change subject: [java] KUDU-3350 add the support for deleteIgnoreRows ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/18211/11/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/18211/11/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@348 PS11, Line 348: deleted ${numDeletes.value.get(tableName)} rows from table '$tableName' I meant this particular log line is confusing. It says that a particular number or rows have been deleted, but that's not true: imagine issuing 1000 DELETE_IGNORE operations to an empty table -- this would report that it has deleted 1000 rows, but in fact it deleted no rows at all. Imagine somebody is looking into a file with these logs, thinking this line reports about the actual number of rows deleted (because it states doing so). It would be misleading. Maybe, change this to be something like "deleted up to ${numDeletes.value.get(tableName)} rows from table '$tableName' using DELETE_IGNORE" -- To view, visit http://gerrit.cloudera.org:8080/18211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f89ced9ffa4a79f46661873f01c38aefb1d78d5 Gerrit-Change-Number: 18211 Gerrit-PatchSet: 11 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Feb 2022 06:45:15 +0000 Gerrit-HasComments: Yes
