Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )
Change subject: [common] fix a bug in Schema::Reset(cols, ...) ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Thank you for the contribution! http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@9 PS6, Line 9: Prior to this patch, Schema::col_offsets_ was not cleared : upon calling Schema::Reset(). This patch addresses the issue. : : A new test scenario is added to cover the corresponding regressions in future. : > You are very kind. I would change it. Thank you for updating the summary and the description! Now it's a bit easier to understand what this patch is about just after reading the commit description. -- To view, visit http://gerrit.cloudera.org:8080/18213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722 Gerrit-Change-Number: 18213 Gerrit-PatchSet: 9 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 15 Feb 2022 16:28:57 +0000 Gerrit-HasComments: Yes
