Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18237 )
Change subject: [schema] use operator==() instead of Equals() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18237/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18237/1/src/kudu/master/master-test.cc@1401 PS1, Line 1401: CHECK(kTableSch > nit: CHECK_EQ? Yeah, I tried that -- unfortunately, CHECK_EQ() requires proper ostream output iterator or method defined for Schema. I decided to not introduce that, so opted for CHECK() here instead. -- To view, visit http://gerrit.cloudera.org:8080/18237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb Gerrit-Change-Number: 18237 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Feb 2022 21:24:16 +0000 Gerrit-HasComments: Yes
