Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18237 )
Change subject: [schema] use operator==() instead of Equals() ...................................................................... [schema] use operator==() instead of Equals() While looking at the code in src/kudu/common/schema.h in the scope of reviewing a prior changelist, I noticed that the comparison options for Schema::Equals() were used only in the test scenarios. I took the liberty and moved the Equals() method into the test code and replaced it with the operator== at call sites. This patch includes other minor cleanup, but overall the patch doesn't contain any functional changes. Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb Reviewed-on: http://gerrit.cloudera.org:8080/18237 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/client/client.cc M src/kudu/client/schema.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/row.h M src/kudu/common/schema-test.cc M src/kudu/common/schema.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/master/master-test.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tserver/tablet_service.cc 13 files changed, 99 insertions(+), 81 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb Gerrit-Change-Number: 18237 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
