Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18253 )

Change subject: [webserver] optional HSTS header for HTTPS responses
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18253/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18253/3//COMMIT_MSG@17
PS3, Line 17: --webserver_hsts_max_age_seconds flag to zero.
> nit: -1
Done


http://gerrit.cloudera.org:8080/#/c/18253/3/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/18253/3/src/kudu/server/webserver.cc@99
PS3, Line 99: s zero "
            :              "or negative
> nit: fix the help text according to the new behavior
Done



--
To view, visit http://gerrit.cloudera.org:8080/18253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id844b9588196b3d608765d0f16f5caec1c414d41
Gerrit-Change-Number: 18253
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Feb 2022 09:01:16 +0000
Gerrit-HasComments: Yes

Reply via email to