Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18253 )
Change subject: [webserver] optional HSTS header for HTTPS responses ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18253/2/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/18253/2/src/kudu/server/webserver.cc@93 PS2, Line 93: 31536000 > I don't know if this feature makes any sense for Kudu, but either way, I do Yep, I agree: I also was under impression that the request to add this was just to please some security scanner :) I don't think we should commit/push this as fast as possible -- let's just have it here and then decide whether we need it at all. Maybe, we'd like to add extra tags for the flag -- something like 'unsafe' or similar :) -- To view, visit http://gerrit.cloudera.org:8080/18253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id844b9588196b3d608765d0f16f5caec1c414d41 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 18 Feb 2022 09:03:39 +0000 Gerrit-HasComments: Yes
