Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18255 )
Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr ...................................................................... Patch Set 3: (2 comments) Good work! http://gerrit.cloudera.org:8080/#/c/18255/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18255/3/src/kudu/tablet/tablet.cc@548 PS3, Line 548: schema().get() Why there are two styles, one is declear a new variable, like 'SchemaPtr schema_ptr = schema()', while another use 'schema().get()' directly? http://gerrit.cloudera.org:8080/#/c/18255/3/src/kudu/tablet/tablet.cc@1616 PS3, Line 1616: SchemaPtr schema(new Schema(new_schema)); How about use std::make_shared? -- To view, visit http://gerrit.cloudera.org:8080/18255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 23 Feb 2022 11:59:45 +0000 Gerrit-HasComments: Yes
