Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18255 )
Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18255/8/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/18255/8/src/kudu/tablet/tablet_metadata.h@379 PS8, Line 379: Set nit: maybe remove the Set here, so it's just SwapSchemaUnlocked http://gerrit.cloudera.org:8080/#/c/18255/8/src/kudu/tablet/tablet_metadata.h@447 PS8, Line 447: // We don't use unique_ptr so that we can do an atomic swap. nit: I'm not sure what this means. There doesn't seem to be much of a difference between swapping a unique_ptr vs a shared_ptr. -- To view, visit http://gerrit.cloudera.org:8080/18255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 8 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 02 Mar 2022 06:42:33 +0000 Gerrit-HasComments: Yes
