Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 )
Change subject: KUDU-3318 [LBM] Runtime compact log container metadata ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/17871/10/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/17871/10/src/kudu/fs/log_block_manager.cc@1339 PS10, Line 1339: // It is invalid to punch a zero-size hole. > Given the new feature is off by default, I'm curious whether the addition o After upgrading partial tservers of some real clusters to include this patch, comparing write/compact related metrics of tservers, I didn't see any noticeable effect on performance. -- To view, visit http://gerrit.cloudera.org:8080/17871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72bdf73fa73403918c01dfa9d45530fad47ecaf6 Gerrit-Change-Number: 17871 Gerrit-PatchSet: 11 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 14 Mar 2022 09:28:28 +0000 Gerrit-HasComments: Yes
