Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 )
Change subject: KUDU-3318 [LBM] Runtime compact log container metadata ...................................................................... Patch Set 10: Code-Review+1 (1 comment) Basically LGTM, though still would like to see this run on a real cluster. Also curious (and maybe it's worth looking at some LBM test timings for it) whether the new lock affects performance. http://gerrit.cloudera.org:8080/#/c/17871/10/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/17871/10/src/kudu/fs/log_block_manager.cc@1339 PS10, Line 1339: shared_lock<RWMutex> l(metadata_compact_lock_); Given the new feature is off by default, I'm curious whether the addition of this lock has a noticeable effect on performance. I suppose concurrent access of metadata would be rare, but it's still worth thinking about. -- To view, visit http://gerrit.cloudera.org:8080/17871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72bdf73fa73403918c01dfa9d45530fad47ecaf6 Gerrit-Change-Number: 17871 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 02 Nov 2021 01:48:05 +0000 Gerrit-HasComments: Yes
