Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18308 )
Change subject: [tools] run intra-location rebalancing in parallel ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc@324 PS1, Line 324: s.message() nit: do you think it's worth adding information about which location had which status? Is that easy to figure out from the logs? http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc@328 PS1, Line 328: if (!status.ok()) { : return status; : } nit: RETURN_NOT_OK(status)? http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc@737 PS1, Line 737: guard nit: maybe name this refresh_lock so it's less error prone (e.g. easy to conflate with the held ksck_lock below -- To view, visit http://gerrit.cloudera.org:8080/18308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fe3ef3ec2fcac57114c97d5b6cd81d5d9953c4 Gerrit-Change-Number: 18308 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Mar 2022 22:13:45 +0000 Gerrit-HasComments: Yes
