Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18308 )
Change subject: [tools] run intra-location rebalancing in parallel ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc@324 PS1, Line 324: s.message() > nit: do you think it's worth adding information about which location had wh Yes, I think that's a good idea. Done. http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc@328 PS1, Line 328: if (!status.ok()) { : return status; : } > nit: RETURN_NOT_OK(status)? Done http://gerrit.cloudera.org:8080/#/c/18308/1/src/kudu/tools/rebalancer_tool.cc@737 PS1, Line 737: guard > nit: maybe name this refresh_lock so it's less error prone (e.g. easy to co renamed into 'refresh_guard' -- To view, visit http://gerrit.cloudera.org:8080/18308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fe3ef3ec2fcac57114c97d5b6cd81d5d9953c4 Gerrit-Change-Number: 18308 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Mar 2022 23:57:42 +0000 Gerrit-HasComments: Yes
