Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18350 )
Change subject: WIP KUDU-3290 support duplication to kafka ...................................................................... Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/common/types.h@65 PS3, Line 65: const size_t size() const { return size_; } > warning: return type 'const size_t' (aka 'const unsigned long') is 'const'- Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/connector.h File src/kudu/duplicator/connector.h: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/connector.h@48 PS3, Line 48: const std::shared_ptr<Schema>& p_schema_ptr, > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.h File src/kudu/duplicator/duplicator.h: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.h@57 PS3, Line 57: const consensus::OpId last_confirmed_opid() const { > warning: return type 'const consensus::OpId' is 'const'-qualified at the to Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.cc File src/kudu/duplicator/duplicator.cc: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/duplicator.cc@109 PS3, Line 109: // TODO deal queue data > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/kafka_connector.h File src/kudu/duplicator/kafka/kafka_connector.h: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/kafka_connector.h@68 PS3, Line 68: using std::map; > warning: using declarations in the global namespace in headers are prohibit Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/kafka_connector.h@69 PS3, Line 69: using std::string; > warning: using declarations in the global namespace in headers are prohibit Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/mock_kafka_connector.h File src/kudu/duplicator/kafka/mock_kafka_connector.h: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/duplicator/kafka/mock_kafka_connector.h@33 PS3, Line 33: explicit MockProducer(const Configuration /* config */) : timeout_ms_(30000) {} > warning: the const qualified parameter #1 is copied for each invocation; co Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/ops/op_driver.cc File src/kudu/tablet/ops/op_driver.cc: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/ops/op_driver.cc@294 PS3, Line 294: if (op_->type() == consensus::FOLLOWER) { > warning: repeated branch in conditional chain [bugprone-branch-clone] Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/tablet_replica.cc@193 PS3, Line 193: TabletReplica::TabletReplica(const consensus::RaftPeerPB& local_peer_pb) : > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/18350/3/src/kudu/tablet/tablet_replica.cc@1389 PS3, Line 1389: deque<std::shared_ptr<WriteOpState>> ops) { > warning: the parameter 'ops' is copied for each invocation but only used as Done -- To view, visit http://gerrit.cloudera.org:8080/18350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018 Gerrit-Change-Number: 18350 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 25 Mar 2022 04:29:24 +0000 Gerrit-HasComments: Yes
