Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18350 )
Change subject: WIP KUDU-3290 support duplication to kafka ...................................................................... Patch Set 6: (2 comments) remove the file. http://gerrit.cloudera.org:8080/#/c/18350/5/src/kudu/duplicator/kafka/mock_kafka_connector.h File src/kudu/duplicator/kafka/mock_kafka_connector.h: http://gerrit.cloudera.org:8080/#/c/18350/5/src/kudu/duplicator/kafka/mock_kafka_connector.h@43 PS5, Line 43: > warning: method 'produce' can be made static [readability-convert-member-fu Done http://gerrit.cloudera.org:8080/#/c/18350/5/src/kudu/duplicator/kafka/mock_kafka_connector.h@59 PS5, Line 59: > warning: method 'flush' can be made static [readability-convert-member-func Done -- To view, visit http://gerrit.cloudera.org:8080/18350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I842476216f09150383d06c7a6f4c53bf7f2ec018 Gerrit-Change-Number: 18350 Gerrit-PatchSet: 6 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:59:02 +0000 Gerrit-HasComments: Yes
