Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18294 )
Change subject: [tools] range rebalancing for 'kudu cluster rebalance' ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Overall this looks good to go! Thanks for the great contribution! http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/rebalance/rebalance_algo-test.cc@998 PS4, Line 998: TEST(RebalanceAlgoUnitTest, FewMovesSameTableRanges) { nit: consider adding some cases for when there's a mix of both having some tablets with ranges and others without http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/tools/rebalancer_tool.cc@602 PS4, Line 602: DataTable skew({ "UUID", "Server address", "Replica Count" }); I think the output here makes a lot of sense, especially to dig into the specifics of each range. Curious if you think it's worth adding a similar skew table that summarizes the results? I think it could be helpful as a summary, though worry showing both by default might be too verbose. -- To view, visit http://gerrit.cloudera.org:8080/18294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d2e19266e993f5e2ae13ba18d323c83db30eac1 Gerrit-Change-Number: 18294 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 02 Apr 2022 01:47:13 +0000 Gerrit-HasComments: Yes
