Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18294 )
Change subject: [tools] range rebalancing for 'kudu cluster rebalance' ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/rebalance/rebalance_algo-test.cc@998 PS4, Line 998: TEST(RebalanceAlgoUnitTest, FewMovesSameTableRanges) { > nit: consider adding some cases for when there's a mix of both having some Done http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/18294/4/src/kudu/tools/rebalancer_tool.cc@602 PS4, Line 602: DataTable skew({ "UUID", "Server address", "Replica Count" }); > Actually I realize now that my suggestion doesn't apply, since the limitati There is a table per range -- you can see how it looks in the description of this changelist. Does it make sense or you meant to add the ranges into the table by some other manner? -- To view, visit http://gerrit.cloudera.org:8080/18294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d2e19266e993f5e2ae13ba18d323c83db30eac1 Gerrit-Change-Number: 18294 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 02 Apr 2022 04:05:18 +0000 Gerrit-HasComments: Yes
