Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 )
Change subject: [tool] Add tool to copy replica from local filesystem ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18374/3/src/kudu/tserver/tablet_copy_service.h File src/kudu/tserver/tablet_copy_service.h: PS3: > Could you separate changes on these tablet_copy_service.{h,cc} into its own OK, I created another CR to do this work, https://gerrit.cloudera.org/c/18379/ http://gerrit.cloudera.org:8080/#/c/18374/3/src/kudu/tserver/tablet_copy_source_session.h File src/kudu/tserver/tablet_copy_source_session.h: PS3: > Instead of introducing the TabletCopyMode enum, did you consider an option Done -- To view, visit http://gerrit.cloudera.org:8080/18374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dcafeaad900b66f297914760c54dba887874e95 Gerrit-Change-Number: 18374 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 03 Apr 2022 15:27:44 +0000 Gerrit-HasComments: Yes
