Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 )
Change subject: [tool] Add tool to copy replica from local filesystem ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/18374/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18374/7//COMMIT_MSG@21 PS7, Line 21: - Using --src_* and --dst_* prefixes to clarify what directories > > a user should stand up a new Kudu tserver at the same machine Thanks for clarifying. So with the first usage pattern in mind, doesn't destination file system have to have the same UUID? Is that a requirement? Otherwise, once the new tablet server is started, all existing Raft quorums will think the new server is not a part of the quorum. Regardless, could you add an end-to-end test for the usage pattern you described (copy a few local tablets, then start up the server, and make sure ksck is healthy) Agreed regarding online process -- definitely trickier to handle races with runtime operations. http://gerrit.cloudera.org:8080/#/c/18374/10/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/18374/10/src/kudu/tserver/tablet_copy_client.cc@1096 PS10, Line 1096: "" nit: why not set this to something like "local replica <uuid>"? -- To view, visit http://gerrit.cloudera.org:8080/18374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dcafeaad900b66f297914760c54dba887874e95 Gerrit-Change-Number: 18374 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 12 Apr 2022 18:30:59 +0000 Gerrit-HasComments: Yes
