Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18402 )
Change subject: WIP [master] Add a rebalance request/response and provide a tool, refact master's rebalance ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/client/client.cc@586 PS3, Line 586: return KuduClient::Data::Rebalance(this); > warning: static member accessed through instance [readability-static-access Done http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/master/catalog_manager.cc@3482 PS3, Line 3482: Status CatalogManager::Rebalance(const RebalanceRequestPB* req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/master/catalog_manager.cc@3483 PS3, Line 3483: RebalanceResponsePB* resp, > warning: parameter 'resp' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/master/catalog_manager.cc@3484 PS3, Line 3484: boost::optional<const std::string&> /*user*/, > warning: the parameter 'user' is copied for each invocation but only used a Done http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/master/catalog_manager.cc@3485 PS3, Line 3485: const security::TokenSigner* /*token_signer*/) { > warning: parameter 'token_signer' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18402/3/src/kudu/master/catalog_manager.cc@3497 PS3, Line 3497: > warning: the parameter 'user' is copied for each invocation but only used a temp reserve it. -- To view, visit http://gerrit.cloudera.org:8080/18402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d506d877662c029a30dca9dd5029b9da4162946 Gerrit-Change-Number: 18402 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 13 Apr 2022 07:42:49 +0000 Gerrit-HasComments: Yes
