Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18402 )

Change subject: WIP [master] Add a rebalance request/response and provide a 
tool, refact master's rebalance
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18402/4/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18402/4/src/kudu/master/catalog_manager.cc@3484
PS4, Line 3484:                                  const boost::optional<const 
std::string&>& /*user*/,
> warning: the parameter #3 is copied for each invocation but only used as a
Done


http://gerrit.cloudera.org:8080/#/c/18402/4/src/kudu/master/catalog_manager.cc@3500
PS4, Line 3500:                                   const optional<const 
string&>& user) {
> warning: the parameter 'user' is copied for each invocation but only used a
Done



--
To view, visit http://gerrit.cloudera.org:8080/18402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d506d877662c029a30dca9dd5029b9da4162946
Gerrit-Change-Number: 18402
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Comment-Date: Wed, 13 Apr 2022 08:13:40 +0000
Gerrit-HasComments: Yes

Reply via email to