Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 )
Change subject: [tool] Add tool to copy replica from local filesystem ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/18374/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18374/12/src/kudu/tools/kudu-tool-test.cc@7986 PS12, Line 7986: for (int i = 0; i < mini_cluster_->num_tablet_servers(); ++i) { > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done http://gerrit.cloudera.org:8080/#/c/18374/12/src/kudu/tools/kudu-tool-test.cc@7989 PS12, Line 7989: auto fs_manager = mini_cluster_->mini_tablet_server(kCopyTserverIndex)->server()->fs_manager(); > warning: the variable 'src_fs_uuid' is copy-constructed from a const refere Done http://gerrit.cloudera.org:8080/#/c/18374/12/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: http://gerrit.cloudera.org:8080/#/c/18374/12/src/kudu/tserver/mini_tablet_server.cc@87 PS12, Line 87: for (int dir = 0; dir < num_data_dirs; dir++) { > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done -- To view, visit http://gerrit.cloudera.org:8080/18374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dcafeaad900b66f297914760c54dba887874e95 Gerrit-Change-Number: 18374 Gerrit-PatchSet: 13 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 13 Apr 2022 10:15:40 +0000 Gerrit-HasComments: Yes
