Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18401 )
Change subject: [unit test] fix some problems at tests. ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/18401/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18401/8//COMMIT_MSG@18 PS8, Line 18: Fix a variable table_rows_limit, it used by a log in mast > If I didn't miss something, is there any change in logs? The log at src/kudu/master/catalog_manager.cc#3660, it no changes. The change is variable table_rows_limit, when table_disk_size_limit and table_row_count_limit all setted, and has reached the table_disk_size_limit, variable table_rows_limit is -1(default) before. http://gerrit.cloudera.org:8080/#/c/18401/8/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/18401/8/src/kudu/util/net/socket-test.cc@132 PS8, Line 132: may > nit: Could you also add a comment here? Done -- To view, visit http://gerrit.cloudera.org:8080/18401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb16c2c68fe5f63d0c4da40e08df1837aca70ab7 Gerrit-Change-Number: 18401 Gerrit-PatchSet: 9 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 16 Apr 2022 03:08:52 +0000 Gerrit-HasComments: Yes
