Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18401 )
Change subject: [unit test] fix some problems at tests. ...................................................................... Patch Set 10: (2 comments) > Patch Set 10: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/18401/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18401/8//COMMIT_MSG@18 PS8, Line 18: Fix a variable table_rows_limit, it used by a log in mast > I got it, thanks for your clarification! ok. I read the the log again, and find the log is ok. It has included information what limit has reached. "table $0 row count is $1, on disk size is $2, row count limit is $3, size limit is $4, writing is forbidden" http://gerrit.cloudera.org:8080/#/c/18401/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18401/10//COMMIT_MSG@9 PS10, Line 9: SocketTest.TestRecvReset maybe fail, adjust timeout to improve : success rate > I'm curious about a couple of things here: 2? A testcase offen failed, when a cr committed, such as the example, SocketTest.TestRecvReset(others case exists). I encounted some times, but no changes which any relevant to it happened. So I want to fix it, make it success not probably fail. 1? I'm not sure the reason, In my env is more steady, By studying the codes, and experiments I this change would help. We can set it 100ms or 50ms and run it to reason it. at my env, eg( 200ms --> 100ms or 50ms)? so change it more larger number is more safely. /opt/code/kudu/src/kudu/util/net/socket-test.cc:144: Failure Value of: s.message().ToString() Expected: contains regular expression "recv error from 127.0.0.1:[0-9]+: Resource temporarily unavailable" Actual: "recv error from unknown peer: Transport endpoint is not connected" (of type std::string) terminate called without an active exception *** Aborted at 1650367177 (unix time) try "date -d @1650367177" if you are using GNU date *** PC: @ 0x7f3598d8d2e7 __GI_raise *** SIGABRT (@0x140644) received by PID 1312324 (TID 0x7f359ca3b980) from PID 1312324; stack trace: *** @ 0x7f359a60c1d1 google::(anonymous namespace)::FailureSignalHandler() @ 0x7f3599114140 (unknown) @ 0x7f3598d8d2e7 __GI_raise @ 0x7f3598d8e6c8 __GI_abort @ 0x7f359989aa95 __gnu_cxx::__verbose_terminate_handler() @ 0x7f3599898a06 (unknown) @ 0x7f3599898a33 std::terminate() @ 0x220997 std::thread::~thread() @ 0x21d2e0 kudu::SocketTest::DoTestServerDisconnects() @ 0x21b29c kudu::SocketTest_TestRecvReset_Test::TestBody() @ 0x7f3599f9df2e testing::internal::HandleExceptionsInMethodIfSupported<>() @ 0x7f3599f93a2b testing::Test::Run() @ 0x7f3599f93b95 testing::TestInfo::Run() @ 0x7f3599f93c85 testing::TestSuite::Run() @ 0x7f3599f94144 testing::internal::UnitTestImpl::RunAllTests() @ 0x7f3599f9e46e testing::internal::HandleExceptionsInMethodIfSupported<>() @ 0x7f3599f94340 testing::UnitTest::Run() @ 0x7f359cc173c1 RUN_ALL_TESTS() @ 0x7f359cc16316 main @ 0x7f3598d79ac5 __libc_start_main @ 0x219029 (unknown) Aborted (core dumped) -- To view, visit http://gerrit.cloudera.org:8080/18401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb16c2c68fe5f63d0c4da40e08df1837aca70ab7 Gerrit-Change-Number: 18401 Gerrit-PatchSet: 10 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 19 Apr 2022 11:29:27 +0000 Gerrit-HasComments: Yes
