Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18420 )
Change subject: [java] Fix a scan bug which will read repetitive rows. ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/18420/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18420/15//COMMIT_MSG@12 PS15, Line 12: f nit: often http://gerrit.cloudera.org:8080/#/c/18420/15/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/18420/15/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@693 PS15, Line 693: if (isFaultTolerant && resp.lastPrimaryKey != null) { Nice catch! BTW, in looking at the differences between 'cb' defined at L558, and this gotNextRow callback, I'm curious: should we be updating other fields? Like the propagated timestamp? Or resource metrics? It shouldn't be in this patch, but thought I'd raise the question, while we're in this area of the code. Are there good reasons we _shouldn't_ be updating those? -- To view, visit http://gerrit.cloudera.org:8080/18420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d6be9df10c1a45cd971b52a0351028c1f5a023f Gerrit-Change-Number: 18420 Gerrit-PatchSet: 15 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 22 Apr 2022 06:31:57 +0000 Gerrit-HasComments: Yes
