Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18420 )
Change subject: [java] Fix a scan bug which will read repetitive rows. ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/18420/15/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java: http://gerrit.cloudera.org:8080/#/c/18420/15/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@54 PS15, Line 54: 90000 > The table has 3 tablets. OK, I see -- thank you for the explanation. You can try using the batchSizeBytes setter for KuduScannerBuilder: https://kudu.apache.org/apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html It's better to keep the amount of data smaller overall and use more data only when necessary -- it adds up when running multiple test scenarios, increasing the overall runtime of the tests. http://gerrit.cloudera.org:8080/#/c/18420/15/java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java@83 PS15, Line 83: harness.getClient().isCreateTableDone(TABLE_NAME)) > I just don't waste the last 1 second. I guess you wouldn't waste the last 1 second -- there is 'break' at line 79, and if anything, you could simply increase the number of retries by one. -- To view, visit http://gerrit.cloudera.org:8080/18420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d6be9df10c1a45cd971b52a0351028c1f5a023f Gerrit-Change-Number: 18420 Gerrit-PatchSet: 18 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 28 Apr 2022 17:38:40 +0000 Gerrit-HasComments: Yes
