Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18446 )
Change subject: [tools] Add '--create_table_replication_factor' flag for 'kudu table copy' ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18446/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18446/1//COMMIT_MSG@9 PS1, Line 9: Now it's possible to specify the replication factor for the : destination table when copying a table. : > nit: how about Done http://gerrit.cloudera.org:8080/#/c/18446/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: PS1: > Please add corresponding test scenario into kudu-tool-test.cc Done http://gerrit.cloudera.org:8080/#/c/18446/1/src/kudu/tools/tool_action_table.cc@1555 PS1, Line 1555: .ExtraDescription("Copy table data to another table; the two tables could be in the same " : "cluster or not. The two tables must h > Is it possible to specify --create_table_replication_factor when not specif --create_table_replication_factor is meaningless when --create_table not set. I've added a validate logic in CopyTable(const RunnerContext& context) -- To view, visit http://gerrit.cloudera.org:8080/18446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a4eebdcf85b5ec3666e023194b8c06d66b0a683 Gerrit-Change-Number: 18446 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 26 Apr 2022 12:25:14 +0000 Gerrit-HasComments: Yes
