Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18446 )

Change subject: [tools] Add '--create_table_replication_factor' flag for 'kudu 
table copy'
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18446/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/18446/3/src/kudu/tools/kudu-tool-test.cc@608
PS3, Line 608: explicitly set it t
> nit:
Done


http://gerrit.cloudera.org:8080/#/c/18446/3/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/18446/3/src/kudu/tools/tool_action_table.cc@656
PS3, Line 656:   }
             :   TableScanner scanner(client, table_name);
             :   scanner.SetOutput(&cout);
             :   s
> Thanks for adding this verification.
You're very kind, thanks!
Done



--
To view, visit http://gerrit.cloudera.org:8080/18446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a4eebdcf85b5ec3666e023194b8c06d66b0a683
Gerrit-Change-Number: 18446
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 27 Apr 2022 12:39:11 +0000
Gerrit-HasComments: Yes

Reply via email to