Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 )
Change subject: [client] KUDU-3351: Add WriteOpMetrics in WriteResponsePB ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18451/1/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/18451/1/src/kudu/tablet/ops/write_op.cc@318 PS1, Line 318: resp_metrics->set_successful_inserts(op_m.successful_inserts); : resp_metrics->set_insert_ignore_errors(op_m.insert_ignore_errors); : resp_metrics->set_successful_upserts(op_m.successful_upserts); : resp_metrics->set_successful_updates(op_m.successful_updates); : resp_metrics->set_update_ignore_errors(op_m.update_ignore_errors); : resp_metrics->set_successful_deletes(op_m.successful_deletes); : resp_metrics->set_delete_ignore_errors(op_m.delete_ignore_errors); > Yes, we want to accumulate per-session metrics on the client side. Does the Yep, it seems the approach in PS2 has addressed that concern. As for the crash while running the test, I'd start with understanding what went wrong in that particular case. Maybe, run the test scenario where it segfaults under debugger and see what's going on. Probably, some field is nullptr while trying do dereference it. Going through the stack of the thread segfaulting and the stacks of other threads could give you some hints: the WriteOpState::response_ pointer field isn't assigned as needed, etc. -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 27 Apr 2022 23:04:14 +0000 Gerrit-HasComments: Yes
