Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 )
Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB ...................................................................... Patch Set 6: (2 comments) ExactlyOnceSemanticsITest.TestWritesWithExactlyOnceSemanticsWithCrashyNodes failed due to mismatch Response content. I'm trying to fix it in patch set 6 by dumping the write operation metrics to response object twice: on Prepare and on Finish. http://gerrit.cloudera.org:8080/#/c/18451/5/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: http://gerrit.cloudera.org:8080/#/c/18451/5/src/kudu/client/batcher.cc@970 PS5, Line 970: if (sp::shared_ptr<KuduSession> session = weak_session_.lock()) { : session->dat > C+17 nit: as a best practice to keep variables local only to the relevant c Done http://gerrit.cloudera.org:8080/#/c/18451/6/src/kudu/tablet/ops/write_op.h File src/kudu/tablet/ops/write_op.h: http://gerrit.cloudera.org:8080/#/c/18451/6/src/kudu/tablet/ops/write_op.h@264 PS6, Line 264: void DumpWriteOpToResponse(consensus::DriverType type); Forgot to write documentation here. -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 28 Apr 2022 23:14:32 +0000 Gerrit-HasComments: Yes
