Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 )
Change subject: [thirdparty] Upgrade glog to 0.6.0 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Thanks for this patch! Aside from the TidyBot and a few trailing whitespaces it looks good to me. I also built thirdparty and kudu locally on a 2019 MBP using macOs Monterey (12.1) successfully. Also did some simple manual tests, kudu seems to start up and function fine. http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch File thirdparty/patches/glog-make-internals-visible.patch: http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch@8 PS2, Line 8: nit: whitespace -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 29 Apr 2022 13:22:01 +0000 Gerrit-HasComments: Yes
