Marton Greber has uploaded a new patch set (#4) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/18460 )
Change subject: [thirdparty] Upgrade glog to 0.6.0 ...................................................................... [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 117 insertions(+), 526 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/4 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]>
