Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18466 )
Change subject: Update RELEASING doc ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc File RELEASING.adoc: http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@43 PS1, Line 43: _compile_the_release_notes Just curious: is this automatically-generated anchor it's necessary to add one? http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@129 PS1, Line 129: git shortlog -sn $PREV..HEAD | wc -l Is this just for stats? http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@130 PS1, Line 130: ff5a562e..${PREV} nit: could this be reduced just to $PREV ? http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@131 PS1, Line 131: ${PREV}..HEAD nit: could this be reduced just to $PREV.. ? http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@136 PS1, Line 136: $PREV..HEAD nit: maybe just $PREV.. http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@435 PS1, Line 435: ./docker/docker-build.py --action push --platforms linux/amd64 linux/arm64 Any preference from where to run this command? http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@439 PS1, Line 439: in : link:https://issues.apache.org/jira/browse/INFRA-23166[JIRA] nit: how about ... via Apache JIRA ticket similar to link:https://issues.apache.org/jira/browse/INFRA-23166[this one] -- To view, visit http://gerrit.cloudera.org:8080/18466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863 Gerrit-Change-Number: 18466 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 02 May 2022 18:22:34 +0000 Gerrit-HasComments: Yes
