Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18466 )
Change subject: Update RELEASING doc ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc File RELEASING.adoc: http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@43 PS1, Line 43: _compile_the_release_notes > Just curious: is this automatically-generated anchor it's necessary to add Yep, it's automatically generated based on the heading. http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@129 PS1, Line 129: git shortlog -sn $PREV.. | wc -l > Is this just for stats? yep, we add how many people contribute to each release, and the names of new contributors, these are useful for that. http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@130 PS1, Line 130: ${PREV} | cut -f > nit: could this be reduced just to $PREV ? Done, don't know why I didn't think of that. http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@131 PS1, Line 131: ${PREV}.. | c > nit: could this be reduced just to $PREV.. ? Thanks for the tip, wasn't familiar with that one :) http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@136 PS1, Line 136: $PREV..` to > nit: maybe just Done http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@435 PS1, Line 435: --- > Any preference from where to run this command? added a note about it http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@439 PS1, Line 439: ou need to be granted permissions by the ASF : infra team, which you can request via an Apache JIRA ticket > nit: how about Done -- To view, visit http://gerrit.cloudera.org:8080/18466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863 Gerrit-Change-Number: 18466 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 03 May 2022 18:01:12 +0000 Gerrit-HasComments: Yes
