Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18434 )
Change subject: KUDU-1644: Simplify InList predicate values based on rowset PK bounds ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18434/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18434/2//COMMIT_MSG@11 PS2, Line 11: Also, the DRS bounds info can be used to skip rows : effectively when we have a predicate on a non-prefix of the primary key and the : leading column(s) have cardinality=1 (as described in KUDU-1291). Was this implemented in this patch? I'm not sure I saw it. http://gerrit.cloudera.org:8080/#/c/18434/2/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/18434/2/src/kudu/tablet/cfile_set.cc@439 PS2, Line 439: spec->SetLowerBoundKey(implicit_lb_key); I'm confused about why we're able to modify the ScanSpec for every CFileSet. The ScanSpec is shared for a single tablet scan, isn't it? Won't modifying it for one CFileSet interfere with the iteration of another CFileSet? -- To view, visit http://gerrit.cloudera.org:8080/18434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c2aa958f19a0b62e40a2ef5eb5365f91cbab80 Gerrit-Change-Number: 18434 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 May 2022 19:07:46 +0000 Gerrit-HasComments: Yes
