Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18434 )
Change subject: KUDU-1644: Simplify InList predicate values based on rowset PK bounds ...................................................................... KUDU-1644: Simplify InList predicate values based on rowset PK bounds Previous we only optimize InList predicates based on tablet PK bounds, we can also optimize it at the DRS level. By adding the implicit PK bounds, InList predicate can be simplified. Also, the DRS bounds info can be used to skip rows effectively when we have a predicate on a non-prefix of the primary key and the leading column(s) have cardinality=1 (as described in KUDU-1291). Benchmark tests result(in slow mode): before Selected 10000 rows cost 2.519996 seconds. # PredicateOnFirstColumn Selected 100 rows cost 2.040003 seconds. # PredicateOnSecondColumn after Selected 10000 rows cost 1.771755 seconds. # PredicateOnFirstColumn Selected 100 rows cost 0.131996 seconds. # PredicateOnSecondColumn Change-Id: Ia9c2aa958f19a0b62e40a2ef5eb5365f91cbab80 Reviewed-on: http://gerrit.cloudera.org:8080/18434 Tested-by: Kudu Jenkins Reviewed-by: Yingchun Lai <[email protected]> --- M src/kudu/common/generic_iterators.cc M src/kudu/common/scan_spec.cc M src/kudu/common/scan_spec.h M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h 6 files changed, 247 insertions(+), 39 deletions(-) Approvals: Kudu Jenkins: Verified Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia9c2aa958f19a0b62e40a2ef5eb5365f91cbab80 Gerrit-Change-Number: 18434 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
