Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18511 )
Change subject: [client] add DISALLOW_COPY_AND_ASSIGN() for a few classes ...................................................................... Patch Set 1: Code-Review+1 Looks good. I check all 'data_' with comment '// Owned' in client.h and schema.h. With this patch, they all either have copy constructor defined or DISALLOW_COPY_AND_ASSIGN macro declared. I wonder though, can we tell clang-tidy to check these kind of occurrences? -- To view, visit http://gerrit.cloudera.org:8080/18511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5369760db3040c0357517903dab6ff4e2acb7656 Gerrit-Change-Number: 18511 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 10 May 2022 16:57:51 +0000 Gerrit-HasComments: No
