Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18511 )
Change subject: [client] add DISALLOW_COPY_AND_ASSIGN() for a few classes ...................................................................... [client] add DISALLOW_COPY_AND_ASSIGN() for a few classes After making the copy constructor and the assignment operator for the ResourceMetrics class private, I took a quick look at the other exported classes in the Kudu C++ client API and added corresponding macro where appropriate. Strictly speaking, this change breaks the ABI compatibility for the Kudu C++ client API, but a code that would use these privatized members was unsafe anyways. I guess it's easier to fix the linker error after upgrading to a newer version of the Kudu client library than have a hidden memory corruption problem in a Kudu C++ application. Change-Id: I5369760db3040c0357517903dab6ff4e2acb7656 Reviewed-on: http://gerrit.cloudera.org:8080/18511 Tested-by: Kudu Jenkins Reviewed-by: Riza Suminto <[email protected]> Reviewed-by: Attila Bukor <[email protected]> --- M src/kudu/client/client.h M src/kudu/client/schema.h 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Riza Suminto: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5369760db3040c0357517903dab6ff4e2acb7656 Gerrit-Change-Number: 18511 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
