Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18568 )
Change subject: KUDU-3373 Key provider interface ...................................................................... Patch Set 3: Code-Review+1 (1 comment) other than some readability stuff mentioned in the comment, it looks good to me http://gerrit.cloudera.org:8080/#/c/18568/3/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/18568/3/src/kudu/fs/fs_manager.cc@467 PS3, Line 467: env_->SetEncryptionKey(server_key.length() * 4, As discussed separately this is a bit hard to understand to be coming from length / 2 * 8 due to the hex encoding. Maybe an explanation comment would make it easier to read. Also it might be helpful to add an explanation comment to SetEncryptionKey() that the key_size is the number of bits. -- To view, visit http://gerrit.cloudera.org:8080/18568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6ccc05fb991f0fd5cbcd8a49f5b23286d1094ac Gerrit-Change-Number: 18568 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 26 May 2022 18:46:20 +0000 Gerrit-HasComments: Yes
