Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18568 )
Change subject: KUDU-3373 Key provider interface ...................................................................... Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/18568/4/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/18568/4/src/kudu/fs/fs_manager.cc@195 PS4, Line 195: initted_(false), > I used the authz_provider model as inspiration. Instead of defaulting to th That makes sense to me -- thanks for the explanation! http://gerrit.cloudera.org:8080/#/c/18568/4/src/kudu/server/key_provider.h File src/kudu/server/key_provider.h: http://gerrit.cloudera.org:8080/#/c/18568/4/src/kudu/server/key_provider.h@32 PS4, Line 32: // Decrypts the server key. : virtual Status DecryptServerKey(const std::string& encrypted_server_key, : std::string* server_key) = 0; : : // Encrypts the server key. : virtual Status EncryptServerKey(const std::string& server_key, : std::string* encrypted_server_key) = 0; > Thought it would be worth indicating that this is the "server key" as oppos That's totally fine with me as is: I was just trying to understand how significant was the 'Server' part. http://gerrit.cloudera.org:8080/#/c/18568/4/src/kudu/util/env.h File src/kudu/util/env.h: http://gerrit.cloudera.org:8080/#/c/18568/4/src/kudu/util/env.h@394 PS4, Line 394: const uint8_t* key, size_t key_size > Done Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6ccc05fb991f0fd5cbcd8a49f5b23286d1094ac Gerrit-Change-Number: 18568 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 01 Jun 2022 20:13:17 +0000 Gerrit-HasComments: Yes
