Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18572 )
Change subject: [Tools] Rebuild master according to part of tables not all tables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18572/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18572/3/src/kudu/tools/master_rebuilder.cc@138 PS3, Line 138: const std::set<string>& filter_tables = strings::Split(FLAGS_tables, ",", nit: you can omit std namespace like string. http://gerrit.cloudera.org:8080/#/c/18572/3/src/kudu/tools/master_rebuilder.cc@404 PS3, Line 404: Status MasterRebuilder::UpdateSysCatalog() { Seems most code is similar to WriteSysCatalog, how about reuse it? -- To view, visit http://gerrit.cloudera.org:8080/18572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d812c8a16228ac937603872161969eb05136eb Gerrit-Change-Number: 18572 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 29 May 2022 09:54:48 +0000 Gerrit-HasComments: Yes
