Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18572 )
Change subject: [Tools] Rebuild master according to part of tables not all tables ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18572/5/src/kudu/tools/master_rebuilder.h File src/kudu/tools/master_rebuilder.h: http://gerrit.cloudera.org:8080/#/c/18572/5/src/kudu/tools/master_rebuilder.h@113 PS5, Line 113: Status UpdateSysCatalog(); nit: Would be better to leave a message describing this new method. http://gerrit.cloudera.org:8080/#/c/18572/5/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18572/5/src/kudu/tools/master_rebuilder.cc@141 PS5, Line 141: if (!filter_tables.empty() && !ContainsKey(filter_tables, table_name)) continue; nit: Maybe move this to L129? So we will not get 'Skipping replica ...' messages of filtered tables. http://gerrit.cloudera.org:8080/#/c/18572/5/src/kudu/tools/master_rebuilder.cc@427 PS5, Line 427: table_to_update Why we should update table/tablet entry? What if the entry doesn't exist before we recover it from tservers? -- To view, visit http://gerrit.cloudera.org:8080/18572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d812c8a16228ac937603872161969eb05136eb Gerrit-Change-Number: 18572 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 08 Jun 2022 17:26:37 +0000 Gerrit-HasComments: Yes
